Skip to content

Share one call-site walker between L1 and L3 #20

Closed as not planned
Closed as not planned

Description

@sinha108

Is your feature request related to a problem? Please describe.
L1 records call sites in buildCallSites (internal/syntactic_analysis/symbol_table.go). L3 has its own copy of the same walk in recordedCalls (internal/dataflow/bodynodes.go), and closures are walked twice the same way (buildInnerCallables and closureUnits). L3 pairs its calls with L1's call keys by position in that walk. A count check catches a change in the number of calls, but not a change in order with the same count.

Describe the solution you'd like
One shared walker that yields call sites and closures in recording order, used by both L1 and L3.

Describe alternatives you've considered
An order assertion on the fixtures. It catches drift only on the shapes the fixtures happen to contain.

Additional context
Found by the task review of PR #16 (Task 11).

Activity

  1. sinha108 commented on Oct 25, 2026

    @sinha108
    ContributorAuthor

    Consolidated into #26, which carries this issue's full detail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions