Repository navigation
feat: preserve narration and write SRT/VTT captions (#3) - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flow-reel record demo.tsnow preserves each step’s original narration and writes SRT/WebVTT captions beside the silent MP4, using the final calibrated video timeline.One cue covers each step’s recorded boundaries. Captions normalize whitespace, let players wrap text, escape markup, and skip blank or zero-duration cues. Schema version 1 still accepts older transcripts without narration.
Evidence
undefined; subtitle files were absent.After: both recording runs preserve narration, and ffprobe reads SRT cue boundaries matching each transcript.
npm run typecheckandnpm run build: passed.npm test: 45 passed.npm run test:e2e: 6 passed, including Chromium’s native WebVTT parsing, literal-text and active-cue playback checks, plus existing resolution, ±150 ms repeatability and two-frame alignment checks.Merge Danger
Door: two-way
Blast Radius: recorder
Adds caption sidecars and narration fields; recording timing and silent MP4 behavior remain unchanged. Some SRT players display escape sequences rather than decoding them; the README documents this limit. WebVTT preserves literal text.
Closes #3