Repository navigation
feat: render cursor, click ripples and automatic zoom (#7) - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
recordnow adds a visible cursor, click ripples and automatic target-aware zoom while preserving narration and every delivery frame.Zoom eases in over 650 ms, holds until 2 seconds after click/typing activity, and eases out over 800 ms. Typing at the same target extends the hold without restarting an unfinished ease. Optional bounds extend version 1 events compatibly; old logs retain point-based framing. The clean master and original WAVs stay intact. No dependencies or public controls added.
Closes #7
Evidence
After: user approved the revised narrated preview; decoded-frame tests verify sprite visibility, ripple timing, target zoom, frame count and identical repeated renders. Same-target typing no longer restarts the zoom.
npm test: 73 tests pass. Type checking, build, package smoke and whitespace checks pass.npm run test:e2e: 24 tests pass before the playback timing revision. Afterward all 11 focused render tests pass on host FFmpeg 9 and image FFmpeg 6; the revised real master/WAV rerender preserves 375 frames / 12.5 seconds. GitHub CI attempts 1 and 2 could not reach tests because Ubuntu package mirrors failed DNS resolution; attempt 3 is still in dependency setup. No required merge checks are configured. Cloud verification remains unconfirmed; local verification and approved playback are the merge evidence.planning/GH-1-narrated-reproducible-feature-demos/tickets/GH-7-render-cursor-zoom-polish/build-notes.md.Merge Danger
Door: two-way
Revert restores the previous plain delivery renderer; no data migration or schema-version break.
Blast Radius: recording
Delivery rendering changes for every recording. Frame/audio guards and both FFmpeg versions are covered; zoom is limited to the captured source, and off-screen content cannot be recovered. Sounds and optional 4K capture remain separate work.