Repository navigation
feat: add click, typing and action sound effects (#8) - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Demos now include click and typing sounds, plus eight explicit action cues through nonblocking
sfx(name). The approved DAEDAL CC0 palette mixes beneath narration with smooth ducking;--no-sfxmutes all effects without changing timing or visuals.Explicit cues: success, error, notification, open, close, toggle, back and select. Selected assets, licences, source hashes and processing recipes are bundled for offline use.
Closes #8
Evidence
After: 80 unit tests and all 30 end-to-end tests pass; type checking, build and staged diff checks pass.
Merge Danger
Door: two-way
Code and assets can be reverted. Original speech WAVs/hashes, narration holds, clean master and captions retain their contracts.
Blast Radius: recording
Effects are enabled by default. New event logs use version 2 for sound cues; updated readers accept version 1, while older readers need upgrading. Transcript schema remains version 1. No new dependencies or runtime downloads.