Repository navigation
feat: unify Windows and Linux Coder Desktop in a single repo - #173
Closed
ibetitsmike wants to merge 3 commits into
Closed
ibetitsmike wants to merge 3 commits into
ibetitsmike wants to merge 3 commits into
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges the coder-desktop-linux Avalonia port back into this repo so one codebase builds and ships Coder Desktop for both Windows and Linux, sharing the VPN service, RPC protocol, and SDKs.
What changed
App.Avalonia(Avalonia UI),App.Shared(UI-agnostic ViewModels/services),App.Linux(Linux service impls),Vpn.Linux(Unix socket RPC transports),Packaging.Linux(deb/rpm/tar/AUR scripts),scripts/run-linux-dev.sh, and therelease-linux.yamlworkflow.Vpn.Service/*,MutagenSdk/MutagenClient.cs,Vpn.DebugClient): runtime OS checks plusWINDOWSconditional compilation preserve existing Windows behavior. Only 27 existing files are touched, each with a focused diff.Vpn,Vpn.Service,Tests.Vpn,Tests.Vpn.Serviceasnet8.0;net8.0-windows.ManagerRpcnow uses anIRpcServerTransportabstraction: named pipes (extracted toNamedPipeServerTransport) on Windows, Unix domain sockets on Linux.Coder.Desktop.Linux.slnf(excludes WinUIApp,Tests.App,Installer),Directory.Build.props(EnableWindowsTargetingon non-Windows hosts only), and NuGet lock files for the new projects.test-linuxandbuild-linuxjobs.end_of_line = crlffrom.editorconfig: the repo is stored with LF line endings and newer dotnet format versions treat the rule as a hard error, which would have forced a whole-repo whitespace rewrite. Existing file bytes are untouched.SpeakerTest.SendMessageWriteError(shutdown race, ~50% failure rate on Linux).Appand AvaloniaApp.Avalonia/App.Sharedremain separate; converging the Windows app ontoApp.Sharedis follow-up work.Validation
aws-linuxworkspace): locked-mode restore ofCoder.Desktop.Linux.slnf, Release build, all test projects green, format verification clean.CoderVpnServiceunder sudo, drove it viaVpn.DebugClientover the Unix socket. VPN started against https://dev.coder.com, downloaded the tunnel binary, and streamed live workspace/agent peer updates with successful P2P handshakes.aws-windows-desktopworkspace): full-solution restore,dotnet test -p:Platform=x64on the shared test projects, Release publish ofVpn.Service(net8.0-windows). The WinUI App publish failures there reproduce identically on unmodifiedmain(environment/SDK drift); CI is authoritative and passes.