🤖 refactor: split createUnderTaskTreeLifecycleLock, part 1: queued branch by ThomasK33 · Pull Request #7702 · coder/xum

ThomasK33 · 2026-10-28T12:31:00Z

Summary

Part 1 of 5: splits the queued branch of TaskService.createUnderTaskTreeLifecycleLock in place into named steps, with no behaviour change. The method drops from CC 122 to CC 113. On top of the test PR #7701. 329 changed lines.

The parts go from the end of the method to its start, as in the drainTerminalAttention split (#7697 to #7699). The code that stays inline must be the start of the method. If a part split the start first, the whole remaining tail had to move into one new step, and the CRAP gate refuses a new function above CC 8.

Steps in this part

createQueuedTask persists the queued row, announces the task and schedules the queue.
appendQueuedTaskEntry is the config-edit callback, now a method.
reserveTaskDesktop is the closure that reserves the desktop owner, now a method.
This part also defines the readonly records TaskCreateRequest, TaskCreateParent, TaskCreatePlacement and TaskCreatePlan. Each one builds on the last with spread.

Rules every part keeps

The method keeps await using _lock = await this.mutex.acquire(). Inside that scope, a bare return promise releases the global mutex before the promise settles. So every call from the method to a step is await or return await, and no step acquires the mutex, which is not reentrant.
The steps form a chain: each step calls the next one directly after its own last await. So no collaborator call runs a microtask later than in the inline code. Only the result of the method resolves later, at approximately 2 microtasks per chain level. The mutex therefore releases that much later, at the same logical point.
make crap-check against the parent commit reports 0 violations, with and without coverage. Every new function scores CC 8 or less.
bun test on the taskService, ledger, workspaceTurnManager, workflows, tools and workspaceService suites: 4,968 pass, 0 fail. These suites include the 27 tests from 🤖 tests: cover createUnderTaskTreeLifecycleLock paths before the split #7701.

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $182.90

…anch Moves the queued branch of TaskService.createUnderTaskTreeLifecycleLock into createQueuedTask and its config edit into appendQueuedTaskEntry. The reserveDesktop closure becomes reserveTaskDesktop. The decided values travel in one readonly TaskCreatePlan record (stage interfaces TaskCreateRequest, TaskCreateParent and TaskCreatePlacement for the later parts). The method still holds the global mutex and calls `return await this.createQueuedTask`, so the lock releases only after the queued result settles. No behaviour change: same awaits, same calls in the same order.

chatgpt-codex-connector · 2026-10-28T12:31:16Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-28T15:04:36.737190Z	`7c61358`	Manual request
🔒 Security Review	✅ Completed 2026-10-28T15:07:30.715655Z	`7c61358`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ThomasK33 · 2026-10-28T12:31:44Z

@codex review

chatgpt-codex-connector · 2026-10-28T12:35:00Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: fbb1a0998f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

github-actions · 2026-10-28T12:36:05Z

🟢 e2e stories (Haiku): 14 passed

22 agent steps · 7 replayed from cache · 15 model calls · 46.3k tokens (28% cached)
Spend: $0.09 of the $1.00 cap (proxy ledger)

All 14 tests in 9 files

	Test	Agent	Time
🟢	chatRestart.e2e.ts · 1 passed	1 step · 1 call	5.5s
🟢	a chat survives a restart of the server	1 step · 1 call	5.5s
🟢	compaction.e2e.ts · 1 passed	1 step · 1 call	4.5s
🟢	/compact replaces the old chat with a summary	1 step · 1 call	4.5s
🟢	pluginTrustRestart.e2e.ts · 1 passed	4 steps · 2 calls	9.6s
🟢	a trusted plugin hook stays trusted after the server restarts	4 steps · 2 calls	9.6s
🟢	settingsRoundTrip.e2e.ts · 1 passed	2 steps · 1 call	8.5s
🟢	a chat survives trips through Settings	2 steps · 1 call	8.5s
🟢	sidebarPerWorkspace.e2e.ts · 1 passed	4 steps · 1 call	4.3s
🟢	a new workspace starts with its right sidebar collapsed while another keeps it open	4 steps · 1 call	4.3s
🟢	smoke.e2e.ts · 1 passed	2 steps · 1 call	2.4s
🟢	the agent opens the playground workspace	2 steps · 1 call	2.4s
🟢	streamErrors.e2e.ts · 1 passed	1 step · 1 call	7.5s
🟢	stream errors show in the chat, and the chat recovers	1 step · 1 call	7.5s
🟢	todoNudge.e2e.ts · 1 passed	1 step · 1 call	4.2s
🟢	the agent finishes open TODO items after the turn-end nudge	1 step · 1 call	4.2s
🟢	touchAlignment.e2e.ts · 6 passed	6 steps · 6 calls	22.9s
🟢	the Settings close button is level with the title on a touch screen 390px wide	1 step · 1 call	4.7s
🟢	the Settings close button is level with the title on a touch screen 768px wide	1 step · 1 call	4.5s
🟢	Backup settings checkboxes are small and level with their labels on a touch phone	1 step · 1 call	4.4s
🟢	the heartbeat checkbox is small and level with its label on a touch phone	1 step · 1 call	3.3s
🟢	a reply's model and time stay on one line on a touch phone	1 step · 1 call	3.4s
🟢	the workspace actions menu stays on the title row on a touch phone	1 step · 1 call	2.6s

_{e2e 0.20.0 · 1m 12s · web · run artifacts}

🟢 e2e Electron stories (Haiku): 3 passed

3 agent steps · 3 model calls · 8.0k tokens (32% cached)
Spend: $0.01 of the $1.00 cap (proxy ledger)

All 3 tests in 3 files

	Test	Agent	Time
🟢	electron/deepLink.e2e.ts · 1 passed	1 step · 1 call	5.6s
🟢	a deep link of a second launch starts a chat in the running app	1 step · 1 call	5.6s
🟢	electron/menuBar.e2e.ts · 1 passed	1 step · 1 call	5.4s
🟢	the workspace menu bar is the desktop title bar	1 step · 1 call	5.4s
🟢	electron/smoke.e2e.ts · 1 passed	1 step · 1 call	5.7s
🟢	Xum Electron opens the playground workspace	1 step · 1 call	5.7s

_{e2e 0.20.0 · 18.6s · electron · run artifacts}

🟢 e2e agent repros (Haiku): no tests selected

Spend: $0.00 of the $1.00 cap (proxy ledger)

_{e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts}

ThomasK33 · 2026-10-28T12:38:22Z

@codex review

chatgpt-codex-connector · 2026-10-28T12:41:10Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 8a661bc33e

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

ThomasK33 · 2026-10-28T12:44:12Z

@codex review

chatgpt-codex-connector · 2026-10-28T12:46:48Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 7c613581ed

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

ThomasK33 · 2026-10-28T15:03:06Z

@codex review

chatgpt-codex-connector · 2026-10-28T15:04:35Z

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: 7c613581ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-28T15:07:28Z

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: 7c613581ed

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

You comment "@codex security review"
A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

ThomasK33 added this pull request to stack #7707 October 28, 2026 12:31

🤖 tests: merge the createUnderLock test fixes from the base branch

8a661bc

🤖 tests: merge the createUnderLock test fixes from the base branch

7c61358

ThomasK33 added this pull request to the merge queue Oct 28, 2026

Merged via the queue into main with commit f28c251 Oct 28, 2026
63 of 66 checks passed

ThomasK33 deleted the refactor/task-create-split-1 branch October 28, 2026 19:47

ThomasK33 mentioned this pull request Oct 28, 2026

🤖 refactor: split sendTreeMessage, part 1: park, dispatch and settle #7709

Open

Navigation Menu

Repository navigation

🤖 refactor: split createUnderTaskTreeLifecycleLock, part 1: queued branch - #7702

🤖 refactor: split createUnderTaskTreeLifecycleLock, part 1: queued branch#7702
ThomasK33 merged 3 commits into
refactor/task-create-testsfrom
refactor/task-create-split-1

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

github-actions Bot commented Oct 28, 2026 •

edited

Loading

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

ThomasK33 commented Oct 28, 2026

Summary

Steps in this part

Rules every part keeps

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

github-actions Bot commented Oct 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🟢 e2e stories (Haiku): 14 passed

🟢 e2e Electron stories (Haiku): 3 passed

🟢 e2e agent repros (Haiku): no tests selected

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

ThomasK33 commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 28, 2026

🛡️ Codex Security Review · Automatically triggered

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

chatgpt-codex-connector Bot commented Oct 28, 2026 •

edited

Loading

github-actions Bot commented Oct 28, 2026 •

edited

Loading