[ThomasK33]

Summary

Adds 12 characterization tests for TaskService.startReservedAgentTaskLeased (the reserved task launch), with no production change. Line coverage of the method goes from 90 % (331 of 369 lines) to 100 %. This is the test PR at the start of stack 10, the last stack of the TaskService recovery and launch path split. A shared-helper PR and the split PRs go on top of it and split the method (CC 65) into named steps.

What the tests cover

The new file is taskService.reservedLaunch.test.ts. Most tests launch through createMany or the queue drain. Two call the lease wrapper startReservedAgentTask directly, as taskService.attemptAdmission.test.ts does, because no public path reaches a row without an attempt id.

• Early exits: a Stop writes interrupted before the launch runs. A stop latch is held and the write back to queued throws. A row without an attempt id, where the stamp write throws, or where another writer stamps a valid id first.
• Materialize: a Stop during the desktop check makes materialize return nothing for a shared task. A Stop right after materialize keeps the parent's runtime unchanged. A shared task whose parent checkout is gone forks and clears taskIsolation.
• Before the send: an attempt retired during sanitize makes the admission refuse, cleans up the fork and fails the launch. A removal during sanitize cleans up. Cancels during the desktop check, after the checkout write and right before the admission send nothing.

The tests check row fields and status, init-log starts and exit codes, registered inits, cleanup and sanitize calls, and sends. No test checks log or message text.

Size

512 changed lines, 12 over the 500-line cap that the plan sets for split PRs. This PR adds only one test file. Moving a test to #7755 would restack 8 PRs and re-run every review to save 12 lines, so it stays one PR.

Validation

• A scratch edit of each covered branch failed its test, and the other tests still passed. I restored the file after each edit.
• The new file passed 120 runs (--rerun-each 10).
• Setup installs tracking for every test. Teardown releases any held stop latch, then waits for every drain, launch, launch-failure handler and background init, also when a test fails early.

---

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high • Cost: $334.45

[ThomasK33]

@codex review

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-30T08:07:19.160590Z	a3a4485	Manual request
🔒 Security Review	✅ Completed 2026-10-30T08:07:12.237413Z	a3a4485	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[chatgpt-codex-connector]

🛡️ Codex Security Review · Automatically triggered

Security review completed. No security issues were found in this pull request.

Reviewed commit: a3a4485064

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

• You comment "@codex security review"
• A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: a3a4485064

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[github-actions]

🟢 e2e stories (Haiku): 14 passed

22 agent steps · 7 replayed from cache · 15 model calls · 46.2k tokens (24% cached)
Spend: $0.09 of the $1.00 cap (proxy ledger)

All 14 tests in 9 files

	Test	Agent	Time
🟢	chatRestart.e2e.ts · 1 passed	1 step · 1 call	5.5s
🟢	a chat survives a restart of the server	1 step · 1 call	5.5s
🟢	compaction.e2e.ts · 1 passed	1 step · 1 call	4.8s
🟢	/compact replaces the old chat with a summary	1 step · 1 call	4.8s
🟢	pluginTrustRestart.e2e.ts · 1 passed	4 steps · 2 calls	9.3s
🟢	a trusted plugin hook stays trusted after the server restarts	4 steps · 2 calls	9.3s
🟢	settingsRoundTrip.e2e.ts · 1 passed	2 steps · 1 call	8.7s
🟢	a chat survives trips through Settings	2 steps · 1 call	8.7s
🟢	sidebarPerWorkspace.e2e.ts · 1 passed	4 steps · 1 call	5.0s
🟢	a new workspace starts with its right sidebar collapsed while another keeps it open	4 steps · 1 call	5.0s
🟢	smoke.e2e.ts · 1 passed	2 steps · 1 call	2.4s
🟢	the agent opens the playground workspace	2 steps · 1 call	2.4s
🟢	streamErrors.e2e.ts · 1 passed	1 step · 1 call	7.0s
🟢	stream errors show in the chat, and the chat recovers	1 step · 1 call	7.0s
🟢	todoNudge.e2e.ts · 1 passed	1 step · 1 call	3.6s
🟢	the agent finishes open TODO items after the turn-end nudge	1 step · 1 call	3.6s
🟢	touchAlignment.e2e.ts · 6 passed	6 steps · 6 calls	21.0s
🟢	the Settings close button is level with the title on a touch screen 390px wide	1 step · 1 call	3.7s
🟢	the Settings close button is level with the title on a touch screen 768px wide	1 step · 1 call	4.1s
🟢	Backup settings checkboxes are small and level with their labels on a touch phone	1 step · 1 call	4.3s
🟢	the heartbeat checkbox is small and level with its label on a touch phone	1 step · 1 call	3.2s
🟢	a reply's model and time stay on one line on a touch phone	1 step · 1 call	3.0s
🟢	the workspace actions menu stays on the title row on a touch phone	1 step · 1 call	2.7s

_{e2e 0.20.0 · 1m 10s · web · run artifacts}

🟢 e2e Electron stories (Haiku): 3 passed

3 agent steps · 3 model calls · 8.0k tokens (22% cached)
Spend: $0.02 of the $1.00 cap (proxy ledger)

All 3 tests in 3 files

	Test	Agent	Time
🟢	electron/deepLink.e2e.ts · 1 passed	1 step · 1 call	6.3s
🟢	a deep link of a second launch starts a chat in the running app	1 step · 1 call	6.3s
🟢	electron/menuBar.e2e.ts · 1 passed	1 step · 1 call	5.6s
🟢	the workspace menu bar is the desktop title bar	1 step · 1 call	5.6s
🟢	electron/smoke.e2e.ts · 1 passed	1 step · 1 call	4.8s
🟢	Xum Electron opens the playground workspace	1 step · 1 call	4.8s

_{e2e 0.20.0 · 18.7s · electron · run artifacts}

🟢 e2e agent repros (Haiku): no tests selected

Spend: $0.00 of the $1.00 cap (proxy ledger)

_{e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts}