Repository navigation
🤖 fix: keep plugin card actions in one place on every card - #7754
Merged
Merged
Conversation
The plugin card header wrapped the name, description, interface details and metadata in one column next to the action buttons. A long description made that column full width, so flex-wrap dropped the buttons to a left-aligned row below. The header now holds only the name, version and badges plus the buttons, so the buttons stay top-right on desktop and wrap right-aligned on phones. Description, interface details and metadata render full width below. Adds InstalledList Desktop/Phone stories with the mix of cards that showed the bug. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_
When a plugin card's actions wrap under the title (phones), they were right-aligned and sat indented from the card text. Drop ml-auto and justify-end: the flex-1 name block already pushes the actions right on the name row, and once wrapped they start flush with the card text. --- _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
🟢 e2e stories (Haiku): 14 passed22 agent steps · 7 replayed from cache · 15 model calls · 46.2k tokens (24% cached) All 14 tests in 9 files
e2e 0.20.0 · 1m 20s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 8.0k tokens (22% cached) All 3 tests in 3 files
e2e 0.20.0 · 23.6s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 5.3s · 2 targets (web, phone) · run artifacts |
Drop the extra App installed-list stories (their phone play threw on the missing group) and assert action placement in the existing Settings stories instead: deploy-tools gets a long description, the desktop play checks Uninstall stays above it, and the phone play checks wrapped actions start flush with the plugin name. _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `high`_ Signed-off-by: Thomas Kosiewski <tk@coder.com>
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Settings > Plugins, each card's action buttons (Manage components, Hooks, Update, Uninstall) moved around. Short cards showed them top right. A card with a long description dropped them to a row under the text, aligned left. This PR puts them in one place on every card.
What changed
InstalledWithUpdateStatesandInstalledPhoneViewportstories gain a long-description plugin and one placement check each. The desktop check fails on the old layout, and the phone check fails on a right-aligned wrap.Scope
Tradeoffs
ml-autoandjustify-endfixes every width, because the name block already grows and pushes the buttons right when they fit.Blast Radius
Only the installed-plugin cards in Settings > Plugins. No logic changed.
Verification
Before (desktop,
release-notescard):After (desktop):
After (phone):
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$2.38