Repository navigation
🤖 refactor: split startReservedAgentTaskLeased, part 4: materialize and checkout reads - #7759
Conversation
…nd checkout reads The materialize step and the row check after it move into two steps that the method calls once, after the desktop admission. No behaviour change. - materializeLaunchCheckout: taskWasShared (read from the row the launch started with), the init log (startWorkspaceInit before the fork), the runtime from the parent's persisted path, the materialize call (still this.materializeReservedTaskWorkspace, which tests spy on), its throw and null exits, then the checkout record with sharesParentCheckout derived from the materialized result, and the abort check. - updateLaunchSourceRuntime: the row check after the fork (gone: cleanup; not starting: end the init log), then the parent's runtime config write and emit when the fork changed it, then the persist step. The row the launch started with is passed in as the snapshot it read before its first await, never re-read. startReservedAgentTaskLeased: CC 32 -> 23. New steps: CC 7, 4. --- _Generated with `xum` • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ <!-- mux-attribution: model=anthropic:claude-opus-5-5 thinking=xhigh -->
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
🟢 e2e stories (Haiku): 14 passed22 agent steps · 7 replayed from cache · 15 model calls · 46.4k tokens (27% cached) All 14 tests in 9 files
e2e 0.20.0 · 1m 12s · web · run artifacts 🟢 e2e Electron stories (Haiku): 3 passed3 agent steps · 3 model calls · 8.0k tokens (32% cached) All 3 tests in 3 files
e2e 0.20.0 · 18.9s · electron · run artifacts 🟢 e2e agent repros (Haiku): no tests selectedSpend: $0.00 of the $1.00 cap (proxy ledger) e2e 0.20.0 · 5.4s · 2 targets (web, phone) · run artifacts |
Summary
Part 4 of 5. It moves the init logger, the runtime and
this.materializeReservedTaskWorkspace(...)intomaterializeLaunchCheckout, and the row check after the fork with the parent's runtime update intoupdateLaunchSourceRuntime. CC 32 → 23. Changed lines: 28, because parts 1 and 3 already moved the code these steps call.No behaviour change: same calls to other methods, same awaits, same order. A script inlines every step and compares the call, await, write, return and throw sequence with the parent commit: identical at every part (it caught
voidforawait, a moved statement and a dropped await in its self-test). Each new step has CC 7 or less, with 100 % line coverage.startReservedAgentTaskandmaterializeReservedTaskWorkspaceare still method calls, so the tests that spy on them still apply. The steps form a chain: each step calls the next right after its own last await, so no write, admission or send moves a microtask later.Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:high• Cost:$351.07