Repository navigation
test: cover joined emoji and max-length GPU parity - #44
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The browser GPU/CPU differential gate covered single-code-point emoji and short queries but omitted joined emoji and the query-length boundary. Extend the existing gate from 10 to 18 comparisons with full ZWJ sequences, emoji components, 128-token ASCII queries, and queries that expand to 128 tokens through case folding, in both substring and fuzzy modes.
Add exact and embedded matches, separate emoji scalars, and final-token near misses so truncation or incorrect sequence handling changes the results. Each browser result is checked against the CPU reference for ordered indexes, integer scores, text, and match counts. Include normalized token counts in test output and update the improvement plan.
Validation
bun run check:shadersbun run typecheckbun run buildbun run test:mockbun run test:parityPR CI passed, including all 18 executing browser GPU/CPU comparisons (eight new cases). CI run. The local ARM host has no Chrome/Chromium installed, so browser validation ran in CI.