fix(forms): keep select options readable in dark and glass styles - #47
Merged
Merged
Conversation
The option list is a native popup that cannot be translucent. Under glassmorphism the select background is rgba(255,255,255,.1), so the popup fell back to the browser's white while options still inherited the light --lc-text: every option except the highlighted one was white-on-white. resonant-stark and dark mode had the same problem. Give option/optgroup the opaque page pair (--lc-text on --lc-bg). Checked in Chromium across all 5 styles x light/dark: 15.1-18.4:1 contrast. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011pv5NUFsXGzyv4F9TcK7Rz
Contributor
|
Message that will be displayed on users' first pull request |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Owner
Author
|
CI note on 2384aa4: Generated by Claude Code |
codinglombok
added a commit
that referenced
this pull request
Oct 1, 2026
…rxmx fix(forms): keep select options readable in dark and glass styles
codinglombok
added a commit
that referenced
this pull request
Oct 3, 2026
…rxmx fix(forms): keep select options readable in dark and glass styles
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<select>options were invisible in styles with light text (glassmorphism, resonant-stark, dark mode): the native option popup cannot be translucent, so it fell back to the browser's white while options inherited the light--lc-text.option/optgroupnow usecolor: var(--lc-text); background-color: var(--lc-bg)(tokens only). Contrast 15.1–18.4:1 across all 5 styles × light/dark.Type
Checklist
src/and rannpm run build; committed updateddist/npm run size:checkpasses