Skip to content

fix(forms): keep select options readable in dark and glass styles - #47

Merged
codinglombok merged 1 commit into
mainfrom
claude/affectionate-sagan-o4rxmx
Sep 30, 2026
Merged

codinglombok merged 1 commit into
mainfrom
claude/affectionate-sagan-o4rxmx

Conversation

@codinglombok

@codinglombok codinglombok commented Sep 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

<select> options were invisible in styles with light text (glassmorphism, resonant-stark, dark mode): the native option popup cannot be translucent, so it fell back to the browser's white while options inherited the light --lc-text.

option / optgroup now use color: var(--lc-text); background-color: var(--lc-bg) (tokens only). Contrast 15.1–18.4:1 across all 5 styles × light/dark.

Type

  • Bug fix

Checklist

  • Edited src/ and ran npm run build; committed updated dist/
  • Components reference tokens only
  • npm run size:check passes
  • Prettier and stylelint pass

The option list is a native popup that cannot be translucent. Under
glassmorphism the select background is rgba(255,255,255,.1), so the
popup fell back to the browser's white while options still inherited
the light --lc-text: every option except the highlighted one was
white-on-white. resonant-stark and dark mode had the same problem.

Give option/optgroup the opaque page pair (--lc-text on --lc-bg).
Checked in Chromium across all 5 styles x light/dark: 15.1-18.4:1
contrast.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011pv5NUFsXGzyv4F9TcK7Rz
@github-actions

Copy link
Copy Markdown
Contributor

Message that will be displayed on users' first pull request

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added documentation Improvements or additions to documentation dist css labels Sep 30, 2026

Copy link
Copy Markdown
Owner Author

CI note on 2384aa4: github-advanced-security failed, not because of this PR. The Copilot autofind job exits before analyzing any code with CAPIError: 400 The requested model is not supported — the same failure seen on #36, #38 and #45 (intermittent; it passed on #44). There is no code fix for it in this repo, and GitHub has refused re-runs of this job (403 This workflow run cannot be retried). The Copilot model configured for that check needs to be updated by the repo owner.


Generated by Claude Code

@codinglombok
codinglombok merged commit 7ed45bb into main Sep 30, 2026
27 of 28 checks passed
@codinglombok
codinglombok deleted the claude/affectionate-sagan-o4rxmx branch September 30, 2026 23:48
codinglombok added a commit that referenced this pull request Oct 1, 2026
…rxmx

fix(forms): keep select options readable in dark and glass styles
codinglombok added a commit that referenced this pull request Oct 3, 2026
…rxmx

fix(forms): keep select options readable in dark and glass styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

css dist documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants