Repository navigation
feat(scan): structured logging for scans (URL, duration, violations, error class) - #130
Merged
Merged
Conversation
ieliofficial
approved these changes
Sep 30, 2026
ieliofficial
left a comment
ieliofficial
left a comment
Member
There was a problem hiding this comment.
Looks good, approving. The full URL in the log was already there before this PR, scanController logs it on every scan request, so I'll open a separate issue to strip query strings in both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #126.
ScanRunner.run()now emits one JSON line per scan ("event":"scan"):console.logon success,console.erroron failure.url,durationMs,violations(count per bucket),totalViolationsurl,durationMs,errorClass,error. Covers SSRF rejection, browser launch failure (previously unlogged), and page/axe errors.Return/throw behaviour is unchanged. Adds a test in
backend/tests/scanRunner.test.js; all 130 backend tests pass.