Repository navigation
Fix free-threaded version parsing - #67
Merged
Merged
Conversation
zsimic
reviewed
Oct 26, 2026
|
|
||
| @pytest.mark.parametrize("prefix", ["", "py", "python", "cpython:"]) | ||
| @pytest.mark.parametrize("version", ["3.14.9", "3.14.10", "3.14.100", "3.14.10rc1", "3.14.10.post1", "3.14.10+local"]) | ||
| @pytest.mark.parametrize(("freethreading", "is_min_spec"), [(False, False), (False, True), (True, False), (True, True)]) |
Collaborator
There was a problem hiding this comment.
is_min_spec is incorrect here... A python spec should be considered "min spec" only if one states something like 3.10+ - a 3.14.10+local is NOT a min spec, it is an invalid spec
All those versions are otherwise valid-ish, but weird (a python spec would never be 3.14.10.post1 for example, it's not a python package... but one could argue "technically correct"
Contributor
Author
There was a problem hiding this comment.
sounds good, I'll make it stricter again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A python version with a two-digit patch version like
3.14.10twould get its suffix matched as.1and0tinstead of.10andtas intended. This simplifies the regex but does make it more accepting, so I'm looking for opinions on whether this is the correct approach,