Repository navigation
Feat/data model - #3
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b91b2df47
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const row = await args.create({ ...args.data, id: randomUUID() }); | ||
| await appendActivity({ | ||
| entityType: args.entityType, | ||
| entityId: row.id, | ||
| action: ACTIVITY_ACTIONS.created, | ||
| actorId: args.actorId, | ||
| payload: { after: audit(row) }, | ||
| }); |
There was a problem hiding this comment.
When the domain write succeeds but the subsequent Activity insert fails (for example, a transient database error), this helper rejects after the new row has already committed. A caller will treat the operation as failed and may retry, creating a duplicate meeting/task while the original has no audit record; the same split-transaction behavior exists in updateRow. Run the mutation and its Activity insert in one transaction.
Useful? React with 👍 / 👎.
| if (!baseUnpooled) { | ||
| skipReason = | ||
| "DATABASE_URL_UNPOOLED is not set, so there is no database to use"; | ||
| } else { |
There was a problem hiding this comment.
In the checked CI workflow, DATABASE_URL_UNPOOLED is supplied only to the separate db:generate step; the later backend test step has no database configuration or service. Consequently this branch always marks the fresh-migration/seed suite skipped in CI, so the newly added migration and database assertions are never exercised there. Provision a disposable Postgres database for that test step and fail rather than skip when it is unavailable.
AGENTS.md reference: AGENTS.md:L54-L58
Useful? React with 👍 / 👎.
1 participant
No description provided.