Repository navigation
Feat/data model - #5
Conversation
Better Auth swallows anything that is not one of its own API errors and
returns Response(null, { status: 500 }), so a database outage reached the
client as an empty 500 and the express error handler never ran.
Set onAPIError.throw so those errors escape better auth, and add an express
error handler that logs the real cause and answers with json. A failed auth
call now reads {"error":"Internal server error"} instead of an empty body,
while better-auth's own API errors keep their json shape.
Covered by a regression test that makes the prisma mock throw.
The step grepped render.yaml for the literal string "prisma migrate deploy", but render.yaml calls it indirectly through npm run db:deploy, so the step failed while the deploy itself was fine. Reword the step to assert both links: render.yaml runs db:deploy, and backend/package.json defines db:deploy as prisma migrate deploy.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e2594f220
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // catches anything a route lets out: db outages, bugs, bad json. | ||
| // without it express falls back to an html body with a stack trace. |
There was a problem hiding this comment.
The repository requires comments to be single line, but this newly introduced comment spans two lines (as does the corresponding note in lib/auth). Collapse each into one line to keep the changed code compliant with the project convention.
AGENTS.md reference: AGENTS.md:L63-L63
Useful? React with 👍 / 👎.
1 participant
No description provided.