fix: accept retrievable builders as subqueries - #329
Merged
Merged
Conversation
elpete
force-pushed
the
fix/quick-builder-subqueries
branch
from
September 15, 2026 22:04
32e46b0 to
8673a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes coldbox-modules/quick#226.
Quick builders recognized through qb’s
isBuildercontract can expose their underlying qb query throughretrieveQuery(). Passing one to a plain qbwhereIn()previously reachedsnapshotBuilder(), which required a concreteQueryBuilderand raised a cast error before SQL compilation.This change unwraps retrievable builders before cloning the subquery, preserving qb’s normal query snapshot, binding, and CTE behavior. It adds a public
whereIn()regression using a retrievable builder fixture.The branch is based on current
next. The PR diff contains only the QueryExecutor change and its two test files; the obsolete TestBox patch is absent.Validation: focused Lucee 6 full-null test passed (1/1),
git diff --checkpassed, and the full 17-job PR matrix passed on8673a64.