Release qb 14.0.0 for breaking upsert and formatter changes - #330
Merged
Merged
Conversation
Pin the corrected CommandBox Semantic Release parser and promote the new upsert and formatter contracts to the major line. BREAKING CHANGE: Custom grammars overriding compileUpsert must accept the trailing matchNulls boolean argument. Native queryExecute returntype, columnkey, and columnKey options are no longer honored; use qb return formatters.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 13.3.0 release missed two BREAKING CHANGE footers because CommandBox Semantic Release only read the third commit-message paragraph. Pin the fixed 3.0.2 parser and add an explicit breaking release commit for the compileUpsert matchNulls argument and replacement of native queryExecute returntype options. This should select 14.0.0 after the plugin fix is published. Validation: the release commit puts the footer in the third paragraph for compatibility with the old parser; git diff --check passed.