Repository navigation
DRYD-1294: Use Native Date Input - #29
Open
mikejritter wants to merge 8 commits into
Open
mikejritter wants to merge 8 commits into
mikejritter wants to merge 8 commits into
Conversation
mikejritter
force-pushed
the
bug/dryd-1294-date-input
branch
from
October 13, 2026 22:59
8425c46 to
448a24c
Compare
Contributor
|
Regarding which version to use in the CHANGELOG, I set it to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1294
The current implementation of the DateInput uses a Dropdown which opens the react-calendar widget, and was flagged in the accessibility audit. This switches to using the browser's native date input as it is generally made to be accessible.
A few notes on some of the changes:
normalizeDateStringas it calls bothnormalizeISO8601DateStringandnormalizeNaturalLanguageDateString. I don't expect we'll have anything with natural language, but it seemed harmless.How should this be tested? Do these changes have associated tests?
"cspace-input": "file:../cspace-input.js",
annotationDatefor CollectionObjectsDependencies for merging? Releasing to production?
The CHANGELOG still needs to be updated. 2.4.0? 2.3.1? I can do it here once we decide.
The tooltip was removed so there's likely some dead code paths from cspace-ui.js now. I don't believe any of the other input components use a tooltip, probably worth checking.
Has the application documentation been updated for these changes?
If there's documentation about the date input it will need to be. I'll search.
Did someone actually run this code to verify it works?
@mikejritter tested locally