Repository navigation
DRYD-2173: Accessibility > Administration: Add Users and Roles > Various Errors - #31
Merged
Merged
Conversation
mikejritter
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It exports the existing
labelToLegendhelper from the package'shelpersWhy are we doing this? (with JIRA link)
https://collectionspace.atlassian.net/browse/DRYD-2173. cspace-ui's
PermissionsInputandRolesInputneed to render their label as a fieldset legend to fix the orphaned form label errors on the Add Role and Add User pages.labelablealready forwards the label to components flagged withuseLegend, but the helper that turns it into a legend was not reachable from outside the package.How should this be tested? Do these changes have associated tests?
Please link this package into cspace-ui and follow the manual steps: collectionspace/cspace-ui.js#381
Dependencies for merging? Releasing to production?
a dev release should be done after merging. The collectionspace/cspace-ui.js#381 depends on this.
Has the application documentation been updated for these changes?
not needed
Did someone actually run this code to verify it works?
@spirosdi ran it locally