Skip to content

DRYD-2174: Custom Toolbar for Quill - #33

Open
mikejritter wants to merge 7 commits into
collectionspace:mainfrom
mikejritter:bug/dryd-2174-quill-btns
Open

mikejritter wants to merge 7 commits into
collectionspace:mainfrom
mikejritter:bug/dryd-2174-quill-btns

Conversation

@mikejritter

@mikejritter mikejritter commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

What does this do?

  • Creates a CustomToolbar for quill with aria-labelled buttons
  • Update colors of quill buttons to match current theme

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2174

The react-quill/quill components in the Taxon form have several alerts related to accessibility. Notably they have empty buttons (where just the svg is used), and an empty link. This updates the toolbar which holds the buttons to provide an aria-label so that there is text to go along with the svgs.

This also includes a small update to the tests by resetting the innerHtml of the <body>, as the selectors were not working correctly when running multiple tests. I figured it's easier to just work from a clean state for each test that worry about it.

How should this be tested? Do these changes have associated tests?
This requires the anthro profile to test, and requires two steps:

  • In cspace-ui.js, update your package.json to point to your cspace-input, e.g. "cspace-input": "file:../cspace-input.js"
  • In your anthro plugin, update the package.json to point to your cspace-ui, e.g. "cspace-ui": "file:../cspace-ui.js"

Once anthro is setup:

  • Start the devserver
  • Create a Taxon
  • When the toolbar popup is active in the Formatted display name editor, verify that the Wave errors do not exist.

Dependencies for merging? Releasing to production?
The empty link warning still exists. I was hoping that I could extend the SnowTheme, but I still need to do some testing. If things work I'll update the PR with the changes.

Likewise the input itself needs to be associated with the label. I'll look into that as well.

A follow up also needs to be done for i18n of the aria-labels in cspace-ui.js.

Has the application documentation been updated for these changes?
n/a

Did someone actually run this code to verify it works?
@mikejritter tested locally using the anthro profile

@mikejritter
mikejritter requested a review from spirosdi October 15, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant