Repository navigation
DRYD-2174: Custom Toolbar for Quill - #33
Open
mikejritter wants to merge 7 commits into
Open
mikejritter wants to merge 7 commits into
mikejritter wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2174
The react-quill/quill components in the Taxon form have several alerts related to accessibility. Notably they have empty buttons (where just the svg is used), and an empty link. This updates the toolbar which holds the buttons to provide an
aria-labelso that there is text to go along with the svgs.This also includes a small update to the tests by resetting the
innerHtmlof the<body>, as the selectors were not working correctly when running multiple tests. I figured it's easier to just work from a clean state for each test that worry about it.How should this be tested? Do these changes have associated tests?
This requires the anthro profile to test, and requires two steps:
"cspace-input": "file:../cspace-input.js""cspace-ui": "file:../cspace-ui.js"Once anthro is setup:
Formatted display nameeditor, verify that the Wave errors do not exist.Dependencies for merging? Releasing to production?
The empty link warning still exists. I was hoping that I could extend the
SnowTheme, but I still need to do some testing. If things work I'll update the PR with the changes.Likewise the input itself needs to be associated with the label. I'll look into that as well.
A follow up also needs to be done for i18n of the aria-labels in cspace-ui.js.
Has the application documentation been updated for these changes?
n/a
Did someone actually run this code to verify it works?
@mikejritter tested locally using the anthro profile