Skip to content

DRYD-2178: Accessibility > Resolve Redundant Title Alerts - #11

Merged
spirosdi merged 1 commit into
masterfrom
bugfix/dryd-2178
Oct 14, 2026
Merged

spirosdi merged 1 commit into
masterfrom
bugfix/dryd-2178

Conversation

@spirosdi

Copy link
Copy Markdown
Contributor

What does this do?
Removes redundant title attribute from Table cell and header. react-virtualized adds a title attribute whenever the passed label is a string. So the title always duplicated the visible text. The changes are:

  • In cellRenderer, wrap cellData in a fragment so that it stops being a plain string
  • Fork default react-virtualized headerRenderer without the title

Why are we doing this? (with JIRA link)
https://collectionspace.atlassian.net/browse/DRYD-2178. A redundant title attribute triggers a WAVE a11y alert.

How should this be tested? Do these changes have associated tests?
Unit tests have been added

For manual test:

  • In cspace-ui.js, update your package.json to use this version of cspace-layout, e.g.
    "cspace-layout": "file:../cspace-layout.js",
  • run the devserver
  • visit any page that contains a react-virtualized table. You may pick any of the pages mentioned in the jira
  • using the WAVE browser plugin, inspect the page and confirm that no "Redundant link" error is reported

Dependencies for merging? Releasing to production?
Publish a patch release after merging

Has the application documentation been updated for these changes?
Changelog has been updated

Did someone actually run this code to verify it works?
@spirosdi ran it locally

@spirosdi
spirosdi requested a review from mikejritter October 13, 2026 08:07
@spirosdi
spirosdi merged commit 5ad4832 into master Oct 14, 2026
5 checks passed
@spirosdi
spirosdi deleted the bugfix/dryd-2178 branch October 14, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants