Skip to content

DRYD-2169: Update modal button colors - #9

Merged
mikejritter merged 2 commits into
collectionspace:masterfrom
mikejritter:bug/dryd-2151
Oct 8, 2026
Merged

mikejritter merged 2 commits into
collectionspace:masterfrom
mikejritter:bug/dryd-2151

Conversation

@mikejritter

@mikejritter mikejritter commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

What does this do?
Updates the button colors for modals to use the new color scheme

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2169

This is for both consistency with the new color scheme as well as meeting wcag requirements.

How should this be tested? Do these changes have associated tests?

  • In cspace-ui.js, update your package.json to use this version of cspace-layout, e.g.
    "cspace-layout": "file:../cspace-layout.js",
  • run the devserver
  • log in as a user with restricted permissions, e.g. reader@core.collectionspace.org
  • execute a search on collectionobjects
  • select some or all objects and try to use the Relate... button
  • the button in the modal's footer should now display the correct color (003366)

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter ran using core.dev.collectionspace.org as a backend

@mikejritter mikejritter changed the title DRYD-2151: Update modal button colors DRYD-2169: Update modal button colors Oct 6, 2026
@mikejritter
mikejritter requested a review from spirosdi October 6, 2026 20:13

@spirosdi spirosdi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor improvement that we can start considering. It makes sense to move the colors.css from cspace-input to cspace-layout and use the variables instead of hardcoded values in all three repos (cspace-ui, cspace-input, cspace-layout). It is not right to import cspace-input in cspace-layout, because this would create a circular dependency. cspace-layout is basically the lowest building block, so the import direction is fine atm. Just the colors.css should be moved to cspace-layout. Definitely not part of this PR, but something we consider for the future.

@mikejritter
mikejritter merged commit 96444ea into collectionspace:master Oct 8, 2026
2 checks passed
@mikejritter
mikejritter deleted the bug/dryd-2151 branch October 8, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants