Repository navigation
DRYD-2169: Update modal button colors - #9
Merged
Merged
Conversation
spirosdi
approved these changes
Oct 8, 2026
spirosdi
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just a minor improvement that we can start considering. It makes sense to move the colors.css from cspace-input to cspace-layout and use the variables instead of hardcoded values in all three repos (cspace-ui, cspace-input, cspace-layout). It is not right to import cspace-input in cspace-layout, because this would create a circular dependency. cspace-layout is basically the lowest building block, so the import direction is fine atm. Just the colors.css should be moved to cspace-layout. Definitely not part of this PR, but something we consider for the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Updates the button colors for modals to use the new color scheme
Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-2169
This is for both consistency with the new color scheme as well as meeting wcag requirements.
How should this be tested? Do these changes have associated tests?
Relate...buttonDependencies for merging? Releasing to production?
None
Has the application documentation been updated for these changes?
No
Did someone actually run this code to verify it works?
@mikejritter ran using core.dev.collectionspace.org as a backend