picker: encode selected color in URL so shared links work - #53
Open
Aditya30ag wants to merge 1 commit into
Open
Aditya30ag wants to merge 1 commit into
Aditya30ag wants to merge 1 commit into
Conversation
✅ Deploy Preview for color-apps ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #52
Problem
The picker only encoded color spaces in the URL (
/picker/oklch+p3), neverthe color value. Sharing a link always opened the default
lch(50 50 50)for the recipient regardless of what was selected.
Changes
picker/index.jsdata()reads?color=on load, with priority overlocalStorageupdateLocation()includes the color in itspushStatecallupdateColorInURL()usesreplaceStateon every color change URL stays shareable without spamming browser history on every slider tickBefore / After
Opening the "after" URL in a other window now restores both the color space and the exact color.