Repository navigation
Conversation
Issue: the specs exercised each method on its own, but not the ways an app combines them, such as an importer recording what it assigns and forging, an editor's override surviving later imports, falling back to the next source, a source authoritative for some attributes, an orphan sweep, and data migrations that delete a source's entries. `spec/lib/usage_spec.rb` adds one group per intention, using a map that places entities from a cadastre, a business directory, a map editor and a geocoder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Issue: the README showed `remove_data_entries(source1)`, which raises because the method takes `attribute_names:` and `sources:` keywords, and it did not say that a marked entry blanks its attribute rather than falling back, which sources can be given as, or that the query scopes also work on `data_entries` and `LaForge::DataEntry`. The usage section now calls `remove_data_entries` inside `forge!` with `sources:` and covers those points, and a new Examples section walks through importing, editor overrides, falling back to the next source, entry priority, a source that stops reporting a record, inspecting where values came from, and pitfalls, matching `spec/lib/usage_spec.rb`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 of 2 tasks
njakobsen
added this pull request to stack #17
October 16, 2026 23:28
Root cause: the workflow ran only for pull requests into `master`, so a pull request stacked on another branch got no test run until the one below it merged and it was retargeted. The `pull_request` trigger no longer filters on the base branch, so every pull request in a stack is tested against its own base. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
timtait
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first of three stacked PRs. This one documents and tests how LaForge is used today, against the current API; the next two build on it.
Changes
spec/lib/usage_spec.rbadds one group per common use: an importer recording what it assigns and forging, an editor's override surviving later imports, falling back to the next source, entry priority, a source that stops reporting a record, an orphan sweep, inspecting where values came from, data migrations that delete a source's entries, forging a new record, and data sources. The examples follow a map that places entities from a cadastre, a business directory, a map editor and a geocoder.remove_data_entries(source1), which raises; it now calls it insideforge!withsources:, and notes that a marked entry blanks its attribute rather than falling back, which forms a source can be given in, and that the query scopes also work ondata_entriesandLaForge::DataEntry.UAT Steps
bundle exec rspec: 106 examples, 0 failures, 2 pending.Closes
Unreported
🤖 Generated with Claude Code