Skip to content

Keep the last closer position in the backtick cache #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuxi-liu-wired wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Keep the last closer position in the backtick cache #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/inlines.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,8 +342,10 @@ static bufsize_t scan_to_closing_backticks(subject *subj,
advance(subj);
numticks++;
}
// store position of ender
if (numticks <= MAXBACKTICKS) {
// store position of ender (keep the last one: a scan that resumes after
// an earlier full scan must not replace a later position)
if (numticks <= MAXBACKTICKS &&
subj->backticks[numticks] < subj->pos - numticks) {
subj->backticks[numticks] = subj->pos - numticks;
}
if (numticks == openticklength) {
Expand Down
13 changes: 13 additions & 0 deletions test/regression.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,19 @@ x <- 1
</code></pre>
````````````````````````````````

Code spans after an unmatched backtick string of a different length.
The failed scan for the closer of ``` `` ``` must not hide the second
single-backtick span.
```````````````````````````````` example
``x
`i`
`j`
.
<p>``x
<code>i</code>
<code>j</code></p>
````````````````````````````````

https://github.com/commonmark/commonmark.js/issues/283
```````````````````````````````` example
x<!x>
Expand Down
Loading