Repository navigation
blocks: handle zero-length chunks in cmark_parser_feed - #635
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S_parser_feeddereferences the first byte of an incoming chunk to detect an LF that continues a CR from the previous chunk, before it has established that the chunk is non-empty, so a streaming caller that handscmark_parser_feeda zero-length chunk gets a one-byte read past the end of its buffer (ASan reports a heap-buffer-overflow atblocks.c:591). That same path then clearslast_buffer_ended_with_crunconditionally, so an empty chunk arriving between a trailing CR and a leading LF is enough to split one paragraph into two.Returning early when
len == 0fixes both symptoms at the point where the chunk length is known, rather than asking callers to filter empty chunks. Worth verifying: the newapi_testcase allocates its chunk at exactly 6 bytes so the overflow is caught by the ASan jobs, and it also fails as a plain assertion in the non-sanitizer builds because the paragraph splits.