Skip to content

Sync design-system tokens to c77c736 - #9

Merged
VatsalSy merged 1 commit into
mainfrom
rayleigh-cloud/sync-ds-coral-text-0652
Oct 16, 2026
Merged

VatsalSy merged 1 commit into
mainfrom
rayleigh-cloud/sync-ds-coral-text-0652

Conversation

@VatsalSy

@VatsalSy VatsalSy commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Vendored site/vendor/ds/tokens.css is now a byte copy of comphy-design-system c77c736. SOURCE_COMMIT records that revision. Asset fingerprints were regenerated with refresh-assets.

Light mode: <strong> uses --c-accent-coral-text (#c04400). The coral chip label is #b03c00 on the existing chip tint. Dark mode keeps the coral fill (#cf4900) for emphasis and #ff9966 for the chip label.

The talks index has no <strong> of its own. The samples below are the index hero with a <strong> and a .chip--coral inserted in the browser so the vendored rules paint on the real page.

Light, before (#cf4900):

Light mode emphasis before

Light, after (#c04400 emphasis, #b03c00 chip label):

Light mode emphasis after

Dark, before:

Dark mode emphasis before

Dark, after (fill unchanged):

Dark mode emphasis after

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Chores
    • Updated the stylesheet version references across three pages.

Light-mode emphasis uses --c-accent-coral-text (#c04400) and the coral chip label is #b03c00, matching DS main for WCAG AA. Dark mode keeps the coral fill.

Co-authored-by: Vatsal Sanjay | CoMPhy Lab <vatsal.sanjay@comphy-lab.org>
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: comphy-lab/talks/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0cbed8c2-133a-4e30-9171-4ff058b8a284
📥 Commits

Reviewing files that changed from the base of the PR and between 7cf9f51 and cf4d588.

⛔ Files ignored due to path filters: 2
  • site/vendor/ds/SOURCE_COMMIT is excluded by !site/vendor/**
  • site/vendor/ds/tokens.css is excluded by !site/vendor/**
📒 Files selected for processing: 3
  • site/index.html
  • site/player/talk.template.html
  • site/singular-bursting-bubbles/index.html

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The tokens.css version query string changes from 8840d1e2d2fcb3cc to b3edde6e153457f4 in three HTML files.

Changes: Stylesheet version updates

Layer / File(s) Summary
Update stylesheet references
site/index.html, site/player/talk.template.html, site/singular-bursting-bubbles/index.html
Each file now references tokens.css with version query string b3edde6e153457f4.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to cf4d5

The stylesheet links now match the updated token asset, and CI checks for stale fingerprints. No actionable merge risk remains from these version updates.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: synchronising the design-system tokens to commit c77c736.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (3 skipped: 3 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@comphy-bot

comphy-bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

comphy-bot review status for comphy-lab/talks#9 at cf4d5889: completed

Review completed for this exact pull request head.

@comphy-bot
comphy-bot self-requested a review October 16, 2026 09:17

@comphy-bot comphy-bot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Sync design-system tokens to c77c736

No P0/P1 findings in the reviewable changes at cf4d588.

The three HTML changes consistently refresh the tokens.css cache-busting value while preserving relative paths and stylesheet ordering. Vendored design-system files are excluded from source-review scope.

Verification: the exact-head validate job succeeded; deterministic conflict-marker and trailing-whitespace checks passed. No peer findings were present in the complete review packet. Deployment was skipped and CodeRabbit was pending at packet collection. No PR code or test scripts were executed; browser rendering and upstream byte-for-byte identity were not independently verified.

@VatsalSy
VatsalSy merged commit 935c51d into main Oct 16, 2026
3 checks passed
@VatsalSy
VatsalSy deleted the rayleigh-cloud/sync-ds-coral-text-0652 branch October 16, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants