WorkflowExecutor.get_by_correlation_ids_and_names calls

[sawmonaco]

Calling WorkflowExecutor.get_by_correlation_ids_and_names function gives:

TypeError: OrkesWorkflowClient.get_by_correlation_ids_in_batch() got an unexpected keyword argument 'include_closed'. Did you mean 'include_completed'?

This is because the WorkflowClient expects include_completed (

python-sdk/src/conductor/client/orkes/orkes_workflow_client.py

Lines 207 to 211 in 3a0516a

	def get_by_correlation_ids_in_batch(
	self,
	batch_request: CorrelationIdsSearchRequest,
	include_completed: bool = False,
	include_tasks: bool = False) -> Dict[str, List[Workflow]]:

)

but include_closed is being sent

python-sdk/src/conductor/client/workflow/executor/workflow_executor.py

Lines 190 to 199 in 3a0516a

	def get_by_correlation_ids_and_names(self, batch_request: CorrelationIdsSearchRequest, include_closed: Optional[bool] = None,
	include_tasks: Optional[bool] = None) -> Dict[str, List[Workflow]]:
	"""
	Given the list of correlation ids and list of workflow names, find and return workflows Returns a map with
	key as correlationId and value as a list of Workflows When IncludeClosed is set to true, the return value
	also includes workflows that are completed otherwise only running workflows are returned
	"""
	return self.workflow_client.get_by_correlation_ids_in_batch(batch_request=batch_request,
	include_closed=include_closed,
	include_tasks=include_tasks)

[nthmost-orkes]

Thanks, get back to you on this Monday!