docs(#3502): add UBI base image bump guidance to AGENTS.md - #3504
docs(#3502): add UBI base image bump guidance to AGENTS.md#3504fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Document the UBI base image update workflow and multi-branch strategy so the review agent understands that release-v* branches intentionally update only production Dockerfiles. Add a new "UBI Base Image Updates" section covering: - The three coordinated Dockerfiles and the bump script - Multi-branch strategy: main updates all three files, release branches may update only production files - Review guidance: do not flag missing acceptance.Dockerfile updates on release branches as stale references Note: pre-commit could not run (sandbox network restriction blocked git fetch for hook environment setup). Manual verification of pre-commit hooks is required. Closes #3502
|
🤖 Finished Review · ✅ Success · Started 6:44 PM UTC · Completed 6:56 PM UTC Commit: |
ReviewFindingsMedium
Low
Labels: PR modifies only documentation (AGENTS.md) |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
| `acceptance/kubernetes/kind/acceptance.Dockerfile` as stale references. The coordinated update set | ||
| defined in `hack/ubi-base-image-bump.sh` applies to `main` branch bumps only. | ||
|
|
||
| ## Troubleshooting |
There was a problem hiding this comment.
[low] technical-accuracy
The statement 'The coordinated update set defined in hack/ubi-base-image-bump.sh applies to main branch bumps only' is misleading. The script itself contains no branch-aware logic — it unconditionally updates all three Dockerfiles. The narrower scope on release branches arises because the script is either not used, or a different mechanism (e.g., Renovate) generates updates independently.
Suggested fix: Rephrase to clarify that the script always updates all three files, but release-branch bump PRs may use a different mechanism that naturally omits acceptance test infrastructure.
There was a problem hiding this comment.
Why does the agent reviewing the a release branch PR even mention files that don't exist in the release branch?
fullsend-ai-review
Bot
added
requires-manual-review
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
simonbaird
left a comment
simonbaird
left a comment
There was a problem hiding this comment.
I don't think we should merge this.
1 participant
What:
Add a new "UBI Base Image Updates" section to AGENTS.md documenting the base image bump workflow, multi-branch update strategy, and review guidance for release branch scope.
Why:
On PR #3498, the review agent flagged a stale-reference finding because
acceptance/kubernetes/kind/acceptance.Dockerfilewas not updated on arelease-v0.7branch UBI bump. The finding was technically correct (the file is in the coordinated set inhack/ubi-base-image-bump.sh) but contextually wrong — release branches intentionally use a narrower scope. AGENTS.md had no guidance about this workflow, so the agent had no way to calibrate severity.This adds the missing context so the review agent can distinguish intentional release-branch scope from actual stale references.
Tickets:
Closes #3502
Post-script verification
agent/3502-agents-md-ubi-bump-guidance)09cafb4dd350366ac857b1fc71ee20fd388b2b40..HEAD)