Repository navigation
build(agentic): upgrade pi to 1.4.0 #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 bug · medium
abortedand unknown stopReasons map tookThe rewritten
modelStatushelper (agentic/run-log/src/projectors/spans.ts:109-113) returns'ok'for every stopReason exceptpending/deferred/error, so a user-aborted turn (stopReason: 'aborted', a member of the union atagentic/run-log/src/transcripts/pi-entry.ts:92) is closed withstatus: 'ok'and a duration. Unrecognized stopReasons from a newer writer are likewise flattened to success, unlike the projector's otherwise-explicitunknownhandling. Trace consumers cannot distinguish a completed turn from a cancelled one.📋 Prompt for AI Agents
In agentic/run-log/src/projectors/spans.ts at modelStatus (lines 109-113), map stopReason 'aborted' to a non-success status — either return 'error' or extend SpanStatus (line 31) with 'aborted' — and add a final branch for unrecognized stopReason values that keeps the span open or returns an 'unknown' status, so aborted and future stopReason semantics are not reported as success. Update spans projection tests to cover an 'aborted' entry and a fabricated stopReason value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not changing this here.
abortedalready mapped tookbefore this PR; only thepending/deferredbranch is new. The rawstopReasonstays on the span, so consumers can tell an aborted turn from a completed one. Adding anabortedstatus widensSpanStatus, which downstream consumers switch on, so it should be its own change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The concern stands. The current diff still shows the same
return stopReason === 'error' ? 'error' : 'ok'fallthrough, meaning'aborted'maps to'ok'. The argument that the rawstopReasonfield is still on the span is reasonable for consumers who inspect that field directly, but it does not address the semantic mismatch ofstatus: 'ok'on an aborted turn — consumers switching onstatusalone will misread it as success. The fix (adding an explicit'aborted'branch or an unknown-fallback) is not visible in this hunk. If it landed elsewhere in the file or in a related file, I will need more context to verify.