fix(deps): drop cryptography from runtime dependencies - #323
Open
AlexanderKomarov wants to merge 4 commits into
Open
AlexanderKomarov wants to merge 4 commits into
AlexanderKomarov wants to merge 4 commits into
Conversation
tmathern
reviewed
Sep 14, 2026
| run: | | ||
| source venv/bin/activate | ||
| pip install dist/c2pa_python-*.whl | ||
| # `[test]` extra pulls cryptography for the callback-signer tests. |
Collaborator
There was a problem hiding this comment.
Instead of mirroring requirements-dev.txt, why not use requirements-dev.txt?
AlexanderKomarov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Not used by the runtime bindings — all crypto happens in the native
c2pa-rs library. Only the tests/examples need it (callback signers), and
it is already declared in requirements-dev.txt. Drop it from the runtime
deps and install requirements-dev.txt in the built-wheel CI jobs.
Checklist
TO DOitems (or similar) have been entered as GitHub issues — N/A (no TODOs)