Repository navigation
feat: Add useExportConfig hook - #214
Merged
Merged
Conversation
gcgoncalves
force-pushed
the
feat/import-export-export-hook
branch
8 times, most recently
from
November 5, 2026 10:54
4942688 to
5234128
Compare
gcgoncalves
force-pushed
the
feat/import-export-export-hook
branch
from
November 5, 2026 11:18
5234128 to
8e9328e
Compare
marekdano
reviewed
Nov 5, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
Small findings below
Missing test for the supersede branch
Nothing checks that a second call aborts the first and isExporting stays true until the second finishes. This is the trickiest logic in the hook.
| "common.team.label": "Team", | ||
| "common.team.placeholder": "Select a team" | ||
| "common.team.placeholder": "Select a team", | ||
| "importExport.export.success": "Configuration exported", |
Contributor
There was a problem hiding this comment.
Do we use this string somewhere?
gcgoncalves
force-pushed
the
feat/import-export-export-hook
branch
from
November 5, 2026 11:42
d368388 to
e7c4f68
Compare
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
Signed-off-by: Gabriel Costa <gabrielcg@proton.me>
gcgoncalves
force-pushed
the
feat/import-export-export-hook
branch
from
November 5, 2026 11:46
e7c4f68 to
9e3a7ff
Compare
marekdano
approved these changes
Nov 5, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
The PR is solid now!
LGTM 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to IBM/mcp-context-forge#7408