Repository navigation
fix: restore standalone E2E TypeScript checks - #218
Merged
Merged
Conversation
Signed-off-by: Vishu Bhatnagar <vishu.bhatnagar@ibm.com>
This was referenced Nov 3, 2026
marekdano
reviewed
Nov 3, 2026
marekdano
left a comment
marekdano
left a comment
Contributor
There was a problem hiding this comment.
The changes looks good!
LGTM 🚀
marekdano
approved these changes
Nov 3, 2026
gcgoncalves
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The standalone E2E TypeScript check fails because Vite environment types are missing and a callback-populated request narrows to
never. Includevite/clienttypes and assert the absence ofparams.server_idon the captured request directly.This is independent of the OAuth feature stack and targets
main.Validation:
tsc -p tsconfig.e2e.json --noEmit, ESLint, and Prettier pass. The full browser suite previously passed with these exact changes: 266 passed, 2 real Keycloak tests skipped.This PR was extracted from #216. The OAuth feature stack is #219 → #220 → #221 → #222.