Repository navigation
Conversation
Part of IBM/mcp-context-forge#7023. Implements #7350 (add an agent that publishes no Agent Card) and the UI side of #7025. - Open a Connect agent form from the Connect agent card - Card flow: read the card from a URL, review it, then collect credentials and visibility and register the agent - "Enter manually" for agents without a card, with name, visibility, endpoint URL, protocol version, authentication (none, basic, bearer, custom headers, OAuth 2.0 client credentials, query parameter), tags and description. Any failed card read shows "Agent card not available" and opens it - Add agentsApi.fetchCard and agentsApi.create, and a shared VisibilityFields component - Add unit tests, e2e tests and en-US, es-ES and pt-BR strings Signed-off-by: Marek Dano <mk.dano@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes IBM/mcp-context-forge#7350
Summary
Builds the Connect agent form for #7023: IBM/mcp-context-forge#7023. It covers #7350 (add an agent that publishes no card) and the UI side of #7025 (register from an Agent Card). It follows the Figma flow.
agentsApi.fetchCardandagentsApi.create, aVisibilityFieldscomponent, and en-US, es-ES and pt-BR strings.Needs attention
POST /v1/a2a/fetch-cardfrom feat(a2a): add POST /a2a/fetch-card to read an Agent Card before registration IBM/mcp-context-forge#7377, which is still open. Until it ships, reading a card fails and the form falls back to manual entry. The response types insrc/types/agentCard.tsare hand-written from that PR. Replace them with generated types onceopenapi.jsonis regenerated.TODO(IBM/mcp-context-forge#7383)mark what to enable.VisibilityFieldslives undercomponents/agents/. The same visibility dropdown is hand-written in six other forms, so it could move tocomponents/common/and be adopted there.Test plan
npx prettier --check src server e2e,npx eslint src server e2e, and typecheck fortsconfig.app.jsonandtsconfig.e2e.jsondetect-secretspre-commit hook passes on the changed filesnpx vitest run --coverage: 3,575 passed, 1 skipped. Coverage meets the repo thresholds (statements 96.3%, branches 90.4%, functions 95.5%,lines 97.5%).
npx playwright test: 298 passed, 2 skipped (API stubbed)a2a.create, register an agent with each manual auth type, and check the card-unavailable messageScreenshots