Repository navigation
Build the docs.rs pages with every feature - #285
Merged
Merged
Conversation
Five crates declare features, so docs.rs built each with its default feature only and left the rest of the surface undocumented. Each now sets `[package.metadata.docs.rs] all-features = true`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
[deepseek-v4.1-flash] The five crates that declare features now build their docs.rs pages with every feature, so the surface behind a non-default feature is documented. docs.rs previously built each with its default feature only.
Motivation
cgp-extragates itsfullfeature andcgp-error-extragatesalloc, whilecgp-macro,cgp-macro-extra, andcgp-async-macrodeclare an empty feature table. Without[package.metadata.docs.rs] all-features = true, a reader of those pages could not see the items a feature adds.Impact
The metadata is inert for the three crates whose feature table is empty, and it keeps their pages correct if a feature is added later.
cargo package --no-verifysucceeds forcgp-type, which validates the manifests.