Repository navigation
fix: a pull request from a fork can run CI and breakage; what needs a secret or a write is skipped - #119
Merged
Conversation
… secret or a write is skipped with a reason A fork's pull request gets no secret and a read-only token. ct-registry is public: without the SSH key it is added from its HTTPS URL (new composite action add-ct-registry). The breakage comment, auto-assign and add-to-project are skipped on a fork instead of failing with a 403 or an empty token; the breakage report stays in the run's summary. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15 (the Krylov.jl approach, extended: ct-registry also needs a secret).
A pull request from a fork gets no secret and a read-only token. Until now its CI failed at
Add ct-registry(Input required and not supplied: ssh-key, seen on OptimalControl.jl#804), and a breakage report would have failed with a 403 on its comment.add-ct-registry: with the SSH key,julia-actions/add-julia-registryas before; without it, ct-registry (public) is added from its HTTPS URL, with General, and a notice says so. Used byci.yml,documentation.yml,breakage.yml,breakage-suite.yml.breakage.yml,breakage-suite.yml: no PR comment on a fork's PR; the report is in the run's summary (added tobreakage.yml, as in Update Breakage.yml for PRs from a fork JuliaSmoothOptimizers/Krylov.jl#978).fork != truerather than== false, so that pushes and manual runs, which have no PR, still comment where they did.auto-assign.yml,add-to-project.yml: skipped on a fork's PR (project_tokenbecomes optional).pull_request_target: CI and breakage run the PR's code.Tested through a real fork PR (control-toolbox/CTBase.jl#630, closed): CI green on the six runners, the breakage matrix and its report green without any comment, Auto Assign and Add to Project skipped. Documentation was not exercised.
🤖 Generated with Claude Code