Skip to content

fix(DevTools): skip Union aliases in _owned_symbols - #620

Merged
ocots merged 1 commit into
mainfrom
fix/aqua-union-alias
Oct 18, 2026
Merged

ocots merged 1 commit into
mainfrom
fix/aqua-union-alias

Conversation

@ocots

@ocots ocots commented Oct 18, 2026

Copy link
Copy Markdown
Member

Fixes #619
_owned_symbols called parentmodule on a Union alias, which has no method, so test_extensions_quality threw for any package defining one.
A Union is now skipped; its members are collected on their own.
A regression test adds two Union aliases to FakePkg.

🤖 Generated with Claude Code

parentmodule has no method for a Union, so test_extensions_quality threw
for any package defining a Union alias. Union members are collected on
their own.

Fixes #619

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@ocots
ocots merged commit 6807be1 into main Oct 18, 2026
3 checks passed
@ocots
ocots deleted the fix/aqua-union-alias branch October 18, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_extensions_quality: parentmodule fails on a Union type alias of the package

1 participant