Repository navigation
Run Aqua on every extension; remove the Makie.plot() piracy - #470
Merged
Merged
Conversation
Applies ct-conventions TST8 through CTBase.DevTools.test_extensions_quality. The only real piracy was Makie.plot(; kwargs...) in CTModelsMakie, now removed: use Makie.Figure(; kwargs...) instead. Closes #466 Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…check Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CTBase.DevTools.test_extensions_quality(CTModels)totest/suite/meta/test_code_quality.jl(ct-conventions TST8): piracy and ambiguities are checked onCTModelsJLD,CTModelsJSON,CTModelsMakie,CTModelsPlots.Makie.plot(; kwargs...)inCTModelsMakie. UseMakie.Figure(; kwargs...)instead (breaking, documented inCHANGELOG.mdandBREAKING.md).Union-alias fix, CTBase#619).Closes #466
Test plan
suite/meta/test_code_qualitypasses locally with CTBase 0.30.12Makie.Figure(; size=…)Generated with Devin