Skip to content

[Dev] Improve some inits #190

Closed
Closed

Description

@jbcaillau

@AmielMetier @HediChennoufi @ocots improve inits of those problems in the list below that have _s versions; if they are here (although they have three versions, including an _s one) it is that, more or less randomly, optimisation with adnlp fails with a sincos domain error (value: -Inf)

 problems_to_exclude = [
        :bioreactor, :cart_pendulum, :dielectrophoretic_particle, :moonlander
        :bioreactor, 
        :cart_pendulum, 
        :dielectrophoretic_particle, 
        :moonlander, 
        :ducted_fan,
        :insurance,
        :robot,
        :space_shuttle,
        :steering,
    ]

Activity

  1. added
    internal devModification to the code is requested and should not affect user experiment
    on Dec 9, 2025
  2. jbcaillau commented on Dec 9, 2025

    @jbcaillau
    MemberAuthor

    @ocots not satisfying to have that many tests removed because of instabilities. what about re-including them, even if there are some fails (e.g. while generating the doc). FTR see control-toolbox/CTBenchmarks.jl#114 (comment) it concerns (at least):

    • insurance
    • robot
    • space_shuttle
    • steering

    and also glider that converges on CPU but not on GPU; would be nice to improve init to have a converging run also on GPU, despite the convergence issue is also informative

  3. AmielMetier commented on Dec 9, 2025

    @AmielMetier
    Collaborator

    @jbcaillau Regarding the problem with inf, isn't it due to the initial value?
    Do we need to perform a custom initialization for each model?

  4. jbcaillau commented on Dec 10, 2025

    @jbcaillau
    MemberAuthor

    @AmielMetier probably, yes. having a better init (= closer to solution) should stabilise the process. to be discussed during next meeting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

internal devModification to the code is requested and should not affect user experiment

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions