Repository navigation
Conversation
Addresses zizmor `artipacked` findings. Signed-off-by: nscuro <nscuro@protonmail.com>
Addresses zizmor `unpinned-uses` findings. Applied via: ``` GH_TOKEN="$(gh auth token)" zizmor --fix=all .github ``` Signed-off-by: nscuro <nscuro@protonmail.com>
Addresses zizmor's `excessive-permissions` findings by scoping permissions to jobs, and explicitly dropping permissions at the workflow-level. Signed-off-by: nscuro <nscuro@protonmail.com>
zizmor flagged this step for cache poisoning risk and recommends configuring it as `lookup-only` (https://docs.zizmor.sh/audits/#remediation_5). However the step appears to be largely ineffective already since Actions cache is scoped to refs (in this case tags). A build for tag v0.1.5 thus wouldn't get cache hits from v0.1.4. A fallback to `master` doesn't exist since nothing writes to the configured cache key for that branch. Opted to remove the step altogether. Signed-off-by: nscuro <nscuro@protonmail.com>
Addresses zizmor's `cache-poisoning` finding. The cache gets populated from builds on `master`, thus posing a real poisoning risk for release builds. Release builds will be slower but that should be fine given they're super infrequent. Signed-off-by: nscuro <nscuro@protonmail.com>
Addresses zizmor `dependabot-cooldown` findings. Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
To be consistent with existing comments. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses all findings reported by zizmor for the project's GitHub Actions workflows.
Adds a new workflow that runs zizmor to ensure no regressions are introduced later.