Skip to content

ci(workflows): register manual full checks - #449

Merged
gunwooterry merged 1 commit into
mainfrom
gunwooterry/register-ci-full
Nov 6, 2026
Merged

gunwooterry merged 1 commit into
mainfrom
gunwooterry/register-ci-full

Conversation

@gunwooterry

@gunwooterry gunwooterry commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR

  • Register the manual full-suite workflow so its implementation can be verified before merging.

Background

GitHub requires a workflow on the default branch before manual dispatch. The implementation in #448 needs exact-head full-suite evidence before it can merge, so registration must land first. Refs #26.

What changes

  • Covered: a dispatch-only, non-required workflow with one harmless no-op. Library and CLI behavior is unchanged.
  • Not covered: builds, media checks, schedules, automatic triggers, failure reporting, secrets, and required checks.
  • After merging: dispatch the full implementation from ci(workflows): shorten PR validation #448's branch and verify its exact head before merging that PR.

Decisions

  • Register separately because GitHub requires this fixed order; keep all real validation in the implementation PR.
  • Grant no token permissions and use no actions or secrets. The workflow does nothing unless manually dispatched.
  • Leave required-check names and their documented table unchanged.

Evidence

Workflow consistency and actionlint pass. A parsed contract check confirms the sole trigger, empty permissions, one bounded no-op job, and unchanged required-check documentation. The no-op executes successfully. Public-text, PR-shape, issue-reference and whitespace checks pass. No Rust changed; the similarity guard is not applicable. All automatic CI checks pass at 88e28e977d335f507b151ab94c59c4e8cec64c3c.

  • Every commit is signed off (git commit -s, DCO).
  • I copied nothing from other implementations.
  • I did not read git history or the archive/m1-prototype tag, except paths named in a port request.

Open in Capy


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Chores
    • Added a workflow that can be started manually for full-suite runs. It currently completes without running checks, so it does not provide test results or change the app’s behavior.

Signed-off-by: Gunwoo Kim <gunwooterry@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Adds a manually triggered GitHub Actions workflow. It grants no permissions, uses an Ubuntu 24.04 runner, sets a one-minute timeout, and runs a step that executes :.

Changes: Manual CI Workflow

Layer / File(s) Summary
Define the manual workflow
.github/workflows/ci-full.yml
Adds a workflow_dispatch workflow with no permissions, an Ubuntu 24.04 runner, a one-minute timeout, and a step that runs :.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to 88e28

The workflow registers a manual no-op without changing required checks. No merge-blocking risk is identified.

Architecture risk: Low · up to 88e28

The changed surface does not map to a changed system, dependency edge, entrypoint, or external dependency.

Changed systems: None identified.

Architecture concerns
No architecture-level concerns identified.

Review details

Before / after behavior

  • observed — Modified behavior in .github/workflows/ci-full.yml: Added the manually triggered ci-full workflow with empty permissions, an Ubuntu 24.04 runner, a one-minute timeout, and a registration step that runs :.
Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly identifies the manual workflow registration.
Description check Passed The description covers the purpose, scope, decisions, follow-up, and verification results. The evidence does not list the exact verification commands.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 1cfe2a5 and 88e28e9.

Files selected for processing: 1

  • .github/workflows/ci-full.yml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

@capy-ai

capy-ai Bot commented Nov 6, 2026

Copy link
Copy Markdown

Review: no blocking issue

Reviewed head 88e28e977d335f507b151ab94c59c4e8cec64c3c.

The sole trigger is workflow_dispatch, permissions are empty, and the bounded job runs only :. There are no secrets or actions to pin. The diff changes no required check or required-check documentation. With no concurrency group, manual runs cannot replace or cancel one another or existing CI runs. The title and body follow the template; DCO is present.

Independently passed python3 scripts/workflow_check.py, the PR title/body shape check, git diff --check, and the no-op shell command. Actionlint was unavailable locally; its reported pass was not independently rerun. No open Greptile findings or CodeRabbit inline findings were present.

CodeRabbit: 0 confirmed, 0 minor, 0 false positive

@gunwooterry
gunwooterry added this pull request to the merge queue Nov 6, 2026
Merged via the queue into main with commit 8448d60 Nov 6, 2026
43 of 44 checks passed
@gunwooterry
gunwooterry deleted the gunwooterry/register-ci-full branch November 6, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant