Repository navigation
fix: two more edge cases in the expansion-share statistical allocation - #44
Merged
jeffseif merged 3 commits intoNov 20, 2026
Merged
Conversation
blallen
approved these changes
Nov 20, 2026
blallen
left a comment
There was a problem hiding this comment.
fixes look good, both have opportunities for generalization later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Claude spotted these
The fixes
get_hectares_per_pixel's calculation uses the spacing between pixels ... but when a raster is only one pixel wide or tall, it yieldsNaNwhich is coalesced to zero downstream. We were calling the function after clipping to jurisdictions which could be smaller than the coarse MAPSPAM grid. The fix is to call the function on the tile before clipping