Repository navigation
WORKER.md: submit long build-server jobs in the background - #1415
Merged
Merged
Conversation
Three worker jobs tonight were stopped when a runner restart cancelled the foreground call that was waiting on them; a background task would have kept running and delivered its completion. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A foreground call that is cancelled stops its build-server job by design. Three worker jobs were lost that way tonight during runner restarts. This asks workers to submit any job that may run over a few minutes with background: true and wait for its completion notice. Docs only.
Summary by cubic
Documents that long build-server jobs should be submitted with
background: true, since a cancelled foreground call (runner restart, lost connection) stops the job by design. Background tasks keep running and deliver a completion notice, which workers should wait for instead of polling. Also adds a non-ranking benchmark harness fixture.Written for commit 6ef85de. Summary will update on new commits.