Skip to content

fix: detect Copilot CLI launched with gh copilot - #34

Merged
corwinm merged 3 commits into
mainfrom
fix/gh-copilot-pane-33
Sep 23, 2026
Merged

corwinm merged 3 commits into
mainfrom
fix/gh-copilot-pane-33

Conversation

@corwinm

@corwinm corwinm commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Discover gh copilot panes only when the foreground GitHub CLI launcher owns a direct Copilot CLI child, or a known npm Node wrapper with a Copilot CLI descendant in the same foreground process group.
  • Preserve standalone copilot detection and optional hook correlation; unrelated gh panes and background children remain excluded.
  • Document both launch paths and add positive/negative process fixtures.

Verification

  • Regression tests failed before each implementation change and pass afterward.
  • Live macOS gh copilot pane appears in list --json --agent copilot and inspect with process:gh-copilot.
  • Installed the Homebrew standalone CLI (1.0.88) and launched it in a separate tmux session; both live panes appeared in list --json --agent copilot and status --summary --json (conservative unknown state without hooks). Verification session was removed afterward.
  • npm test (249 passed), npm run typecheck, npm run lint, npm run fmt:check, npm run shell:check, npm run shell:fmt:check passed locally.

Closes #33

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T04:28:22.433568Z dd72501 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5e1d4224fa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/tmux.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd72501ed5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/tmux.ts
@corwinm
corwinm merged commit 49c8d68 into main Sep 23, 2026
1 check passed
@corwinm
corwinm deleted the fix/gh-copilot-pane-33 branch September 23, 2026 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Detect Copilot CLI panes launched through gh copilot

1 participant