Skip to content

fix: retain Copilot idle status for live tmux panes - #36

Merged
corwinm merged 3 commits into
mainfrom
fix/copilot-idle-persistence
Sep 24, 2026
Merged

corwinm merged 3 commits into
mainfrom
fix/copilot-idle-persistence

Conversation

@corwinm

@corwinm corwinm commented Sep 23, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Use a recognizable live Copilot prompt to report heuristic idle on a fresh CLI or after hook state expires, as the plugin already does for other agents.
  • Keep hook-backed running/waiting/idle state bounded to 60 seconds. An unreadable or unrecognized pane remains unknown; an old hook session ID is never carried into preview state.
  • Support both standard and sidebar composer frames observed in live tmux panes.

Verification

  • Reproduced fresh and post-prompt Copilot UI in isolated tmux panes. The development CLI classified the existing _dotfiles:1.0 pane as idle from copilot-preview after its hook state had expired.
  • New regressions cover stale hook identity, unreadable/busy preview, fresh prompt, fresh blocking hook precedence, sidebar layout, and historical interrupt text in scrollback. The original persistence test failed before the fix; preview-specific tests failed before implementation.
  • npm run fmt:check, npm run lint, npm run typecheck, npm run shell:check, npm run shell:fmt:check, npm test (253 passing), git diff --check.

The initial unbounded hook-idle approach was replaced after review because a missed event or PID reuse could otherwise leave a false idle indefinitely.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-23T22:46:14.390239Z 4182036 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c325b672d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/core/copilot.ts Resolved
@corwinm
corwinm marked this pull request as draft September 23, 2026 22:20
@corwinm
corwinm marked this pull request as ready for review September 23, 2026 22:43
@corwinm
corwinm merged commit 40eed7c into main Sep 24, 2026
1 check passed
@corwinm
corwinm deleted the fix/copilot-idle-persistence branch September 24, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant