Skip to content

fix: scope cycle acknowledgement to tmux server lifetime - #40

Merged
corwinm merged 1 commit into
mainfrom
fix/cycle-server-lifetime
Oct 5, 2026
Merged

corwinm merged 1 commit into
mainfrom
fix/cycle-server-lifetime

Conversation

@corwinm

@corwinm corwinm commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Summary

Closes #39.

  • Scope cycle acknowledgement and status timestamps to the tmux server lifetime plus pane ID.
  • Capture server PID, start time, and socket in the pane snapshot; hash that identity into a server-specific ledger directory.
  • Ignore legacy unscoped records and disable persistent history when server identity is unavailable.
  • Preserve attention history through detach/reattach and same-server pane survival; reset it after a full restart, including the same socket.
  • Document the fresh attention sweep after restart without changing tmux-resurrect behavior.

Verification

  • Test-first: four regressions failed before production changes; focused ledger/server tests now pass 10/10.
  • Real tmux tests exercise concurrent servers with reused pane IDs, control-mode attach/detach/reattach, same-server session churn, and restart on the same socket.
  • Full suite passes 280/280 in a normal-clone snapshot; all nine committed files were byte-verified against that snapshot.
  • Prepared worktree passes 279/280. The remaining sync-plugin test fails because rsync's .git/ exclusion does not exclude a worktree .git file. The identical failure was reproduced on the unchanged baseline (274/275); unrelated sync behavior was not modified.
  • Passed lint, typecheck, formatting, CLI smoke check, shellcheck, shell formatting, and diff whitespace checks.
  • Independent Codex reviews of both the uncommitted change and committed base-to-head diff found no actionable regressions. Reviewer sandbox restrictions prevented its real-tmux tests; the external real-tmux runs passed.

Limits

  • Old server ledger directories are retained; pruning is separate housekeeping.
  • Server identity uses tmux PID/start-time/socket metadata. An exact tuple collision is theoretically possible with PID reuse and identical second-resolution start time.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T23:43:28.793072Z 2b1c169 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@corwinm
corwinm merged commit 01ef58c into main Oct 5, 2026
1 check passed
@corwinm
corwinm deleted the fix/cycle-server-lifetime branch October 5, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope cycle acknowledgement state to the tmux server lifetime

1 participant