Repository navigation
fix(deps): remediate critical tinypool advisories via oxfmt 0.74.0 - #42
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security remediation
oxfmt0.41.0 → 0.74.0, its matching native bindings, and its upstream-pinnedtinypool2.1.0 → 2.2.0. Onlypackage.jsonandpackage-lock.jsonchange; no routine dependency drift or overrides.npm audit --json: two critical affected packages (oxfmt,tinypool). Updated audit: zero vulnerabilities.npm ls oxfmt tinypool --allconfirms the only path isoxfmt@0.74.0 → tinypool@2.2.0.Explicit pre-1.0 breaking-version migration review
This is a separate security/tooling migration, not a routine patch/minor sweep. Use the maintained upstream parent release recommended by audit, rather than overriding an older parent's exact Tinypool pin.
^20.19.0 || >=22.12.0; repository Node>=24.0.0and CI Node 24 satisfy it. Local verification used Node 24.22.1.printWidth: 100JSON configuration/schema, EditorConfig, and lint-staged invocations work unchanged. No Prettier migration command, Rust crate API, Vite+, Astro or Svelte integration is consumed here; their migration/optional peer changes need no repository edits.child_processworkers. Native Markdown checks alone do not establish worker compatibility, so external HTML and actual worker exports were exercised separately.Verification
npm cinpm run fmt:checknpm run shell:fmt:checknpm run lintnpm run shell:checknpm run typechecknpm run check(real CLI help)npm test— 284/284 pass in a disposable normal clone with the exact same base and candidate package files; see worktree caveat below.npm audit --json— zero vulnerabilitiesnpm ls oxfmt tinypool --allgit diff --checkand parsed lockfile comparison — importer, oxfmt/native bindings and Tinypool onlyformatFilenamed worker tasks format Markdown and HTML under bothchild_processandworker_threads, thendestroy()completes. Harmless inherited constructorexecArgv/envand per-runfilenameprobes prove inherited options are ignored.48ebbbd381747484691748cd76303ef061ae805c.Existing worktree-only test failure
In the linked worktree,
npm testgives 283 passes and one failure:--restore returns a synced TPM checkout to a clean install. The sync script excludes.git/directories, not linked-worktree.gitfiles; macOS rsync fails with.git: unlinkat: Directory not empty. The same focused test fails on unchangedorigin/mainin a detached sibling worktree. Applying this exact candidate diff to a disposable normal clone makes all 284 tests pass. This unrelated sync-script issue is not changed in this security PR; normal-checkout Linux CI remains the remote authority.Remote checks are reported by GitHub on this PR's exact head. No merge or auto-merge is requested.
Remote CI
Exact-head workflow run passed for
abe0ccf581f4fb000168129c1a1b9272263ba53c.CI emits an existing Actions Node 20 deprecation annotation for checkout/setup-node v4 (runner forces Node 24); action-version drift is deliberately outside this focused remediation.