Conversation
The SyncMsg rejection log line named the failing property but not the document, so the document ID could only be found by correlating a separate Debug-level line for the same message number. The Info-level line now includes the ID when the request carries one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Droid finished @RIT3shSapata's task —— View job The production change is small and matches the intent to include doc IDs in BLIP rev rejection logs, with correct UD tagging. One test reliability issue remains, it uses require.* inside AssertLogContains and can leave the console logger redirected on failure. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved blocking issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Adds redacted document IDs to BLIP rejection logs and verifies the behavior with a regression test.
Changes:
- Includes document IDs in applicable
SyncMsgrejection logs. - Adds coverage for rejected revision logging.
| File | Summary |
|---|---|
rest/blip_api_crud_test.go |
Verifies rejected revisions log the document ID. |
db/blip_sync_context.go |
Adds redacted document IDs to rejection logs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
![factory-droid[bot]](https://avatars.githubusercontent.com/in/358017?s=60&v=4){kind=small}
require.* can call runtime.Goexit, which would skip the logger restore that runs after the closure returns and could affect later tests in the package. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@droid review |
|
Droid finished @RIT3shSapata's task —— View job Change cleanly adds a UD-tagged doc ID to BLIP rev rejection INFO logs when the request carries one, and includes a focused regression test. No additional issues found in the diff. |
CBG-5857
Add the document ID to the rejection log line, so it does not need to be correlated with a separate Debug-level line.
SyncMsgrejection log line when the BLIP request carries one (coversrevrejections, including the reserved-internal-property case from the ticket)Pre-review checklist
base.UD(docID),base.MD(dbName))docs/api— not applicable, no REST API changeDependencies (if applicable)
Integration Tests
🤖 Generated with Claude Code