The ELM tests for Quantity and Ratio (test/elm/quantity/quantity-test.ts and test/elm/ratio/ratio-test.ts) don't actually interact w/ any compiled CQL, ELM JSON, or even their respective ELM classes (src/elm/quantity.ts and src/elm/ratio.ts). They are really just testing the datatype classes and math utils.
These tests should be reviewed to see if they provide unique value or if they are redundant with existing unit tests elsewhere. Tests that are redundant should be deleted. Tests that are not redundant should be moved to more appropriate tests suites (not ELM). New tests should be added that use real CQL and ELM JSON to verify that CQL Quantities and Ratios are properly converted to their respective data types when executed.
The ELM tests for Quantity and Ratio (
test/elm/quantity/quantity-test.tsandtest/elm/ratio/ratio-test.ts) don't actually interact w/ any compiled CQL, ELM JSON, or even their respective ELM classes (src/elm/quantity.tsandsrc/elm/ratio.ts). They are really just testing the datatype classes and math utils.These tests should be reviewed to see if they provide unique value or if they are redundant with existing unit tests elsewhere. Tests that are redundant should be deleted. Tests that are not redundant should be moved to more appropriate tests suites (not ELM). New tests should be added that use real CQL and ELM JSON to verify that CQL Quantities and Ratios are properly converted to their respective data types when executed.