Repository navigation
fix(#163): make bin/lint.sh portable and fail fast - #181
Merged
s2x merged 1 commit intoNov 6, 2026
Merged
Conversation
s2x
deleted the
fix/issue-163-bug-bin-lint-sh-is-not-portable-and-fail
branch
November 6, 2026 20:42
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
bin/lint.shwas Linux-x86_64-only in practice and failed confusingly on a cleanclone without
vendor/.xargs -0 -rpipelines with bash loops(
run_shellcheck/run_hadolint) that keep a sticky failure status, so oneclean file cannot mask an earlier failure and BSD/macOS
xargsis not needed.vendor/preflight before any PHP tool:composer install(or
bin/worktree-setup.sh) is named and the script exits 1..lint-tools.envsource with a readable-check and a clear error.checksum-verifying install command, macOS gets
brew install <tool>plus therelease link, other platforms are pointed at the release asset (CI pins Linux
x86_64).
AGENTS.md/README.mdstate the supported hosts and the fail-fast behaviour;CHANGELOG.mdrecords the fix under[Unreleased]/Fixed.Closes #163
How it was tested
bash -n bin/lint.sh,shellcheck bin/lint.sh .lint-tools.env,actionlint .github/workflows/ci.yml,git diff --checkpass.PATH=/tmp/opencode/bin:$PATH bin/lint.shpasses on Linux.vendor/prints thecomposer installmessage and exits1 before PHP tools; missing
.lint-tools.envprints the clear error..shand a bad Dockerfile reportsFailed: shellcheck hadolintand exits 1; a clean repo exits 0.unamefor Linux x86_64, Darwin arm64/Intel and Linux arm64; eachhint matches the platform. A
bash:3.2container confirms the new constructswork on macOS's system bash.
Checklist
CHANGELOG.mdupdated under[Unreleased]fix: ...)